EvseManager: Fix bug where HLC is not stopped on unexpected CP state #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be happy if it could be tested again independently of me. I am not completly sure if the new event state CPEvent::BCDtoEF could lead to unexpected behavior. |
Before the HLC session was not stopped by the EvseManager module in case of an unexpected CP state transition while charging. Now the HLC session is stopped in case of a CP state transition C/D -> B/E/F. Signed-off-by: Fabian Hartung <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/stop_hlc_on_unexpected_cp_state
branch
from
c215d50 to
5f508a9
Compare
Don't really have the time to test this at the moment, but it looks good to me. As far as I can see the additional BCDtoEF will not cause side effects. It will trigger a SLAC->leaveBCD, but this does not do anything as far as I can see in the slac implementation. |
corneliusclaussen
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the HLC session was not stopped by the EvseManager module in case of an unexpected CP state transition while charging. Now the HLC session is stopped in case of a CP state transition C/D -> B/E/F.
Describe your changes
Implemented CPEvent::BCDtoEF event. Stop HLC session in case of CP state transition C/D -> B/E/F.
Issue ticket number and link
#668
Checklist before requesting a review